Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Migrate from google search to bing web search #93

Merged
merged 1 commit into from
Jun 6, 2019

Conversation

nareddyt
Copy link
Owner

@nareddyt nareddyt commented Jun 6, 2019

Migrated from Node.js Google to Microsoft Cognitive Services' Bing Web Search v7.

Background

tools/dataProcessor.js currently does multiple web searches to map each discover cashback name to a hostname. Historically, this has been done with the Node.js Google package. However, this is no longer maintained and was not working correctly when I tried updating the Discover Cashback data. As mentioned in jprichardson/node-google#63, this is honestly not the best way to be doing Google Searches.

I looked into the Google Custom Search API, but that was expensive. For our use-case, I decided that the Bing Web Search API should suffice.

Testing Done

  • Validated raw data is correctly processed into the json files

Other changes

  • Documentation updates

@nareddyt nareddyt added enhancement New feature or request data-update Related to updating deals.json or cashbacks.json labels Jun 6, 2019
@nareddyt nareddyt self-assigned this Jun 6, 2019
@nareddyt nareddyt merged commit fe50674 into master Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
data-update Related to updating deals.json or cashbacks.json enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant