Fix rendering of manifest reference table. #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The schema.json file at https://github.com/napari/npe2/releases/latest/download/schema.json also needs to be updated after this PR is merged.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 37 37
Lines 2774 2774
=========================================
Hits 2774 2774 ☔ View full report in Codecov by Sentry. |
DragaDoncila
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Thanks @melissawm! @nclack do you know how to update that schema file?
It'll happen automatically. There's a step in the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The schema.json file at https://github.com/napari/npe2/releases/latest/download/schema.json also needs to be updated after this PR is merged.
Fixes #308 (not the bold part though, that will only be fixed with the new theme)