-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backend/feat/split_settlement #613
Open
0utkarsh
wants to merge
1
commit into
main
Choose a base branch
from
backend/feat/split_settlement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
September 11, 2024 08:10
f13199e
to
6ab20d6
Compare
Could you update this PR with latest commits from |
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
September 24, 2024 13:59
f197b13
to
15af26d
Compare
hkmangla
approved these changes
Oct 1, 2024
@@ -159,6 +187,23 @@ data OrderStatusResp | |||
deriving stock (Show, Read, Eq, Generic) | |||
deriving anyclass (FromJSON, ToJSON, ToSchema) | |||
|
|||
data SplitSettlementResponse = SplitSettlementResponse | |||
{ splitDetails :: [SplitDetailsResponse], | |||
splitApplied :: Bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make it also Maybe.
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
2 times, most recently
from
October 1, 2024 09:20
e7c6140
to
e20fe05
Compare
hkmangla
requested changes
Oct 1, 2024
lib/mobility-core/src/Kernel/External/Payment/Interface/Types.hs
Outdated
Show resolved
Hide resolved
lib/mobility-core/src/Kernel/External/Payment/Juspay/Types/Common.hs
Outdated
Show resolved
Hide resolved
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
October 1, 2024 11:37
e20fe05
to
0f3aa41
Compare
0utkarsh
force-pushed
the
backend/feat/split_settlement
branch
from
October 18, 2024 10:42
0f3aa41
to
33a7e43
Compare
khuzema786
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Additional Changes
Motivation and Context
How did you test it?
Checklist
./dev/format-all-files.sh