Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/feat/split_settlement #613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0utkarsh
Copy link
Member

@0utkarsh 0utkarsh commented Sep 4, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

Description

Additional Changes

  • This PR modifies the database schema (database migration added)
  • This PR modifies dhall configs/environment variables

Motivation and Context

How did you test it?

Checklist

  • I formatted the code and addressed linter errors ./dev/format-all-files.sh
  • I reviewed submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@0utkarsh 0utkarsh force-pushed the backend/feat/split_settlement branch 2 times, most recently from f13199e to 6ab20d6 Compare September 11, 2024 08:10
@srid
Copy link
Member

srid commented Sep 11, 2024

Could you update this PR with latest commits from main? We now use github runners.

@0utkarsh 0utkarsh force-pushed the backend/feat/split_settlement branch 2 times, most recently from f197b13 to 15af26d Compare September 24, 2024 13:59
@@ -159,6 +187,23 @@ data OrderStatusResp
deriving stock (Show, Read, Eq, Generic)
deriving anyclass (FromJSON, ToJSON, ToSchema)

data SplitSettlementResponse = SplitSettlementResponse
{ splitDetails :: [SplitDetailsResponse],
splitApplied :: Bool
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make it also Maybe.

@0utkarsh 0utkarsh force-pushed the backend/feat/split_settlement branch 2 times, most recently from e7c6140 to e20fe05 Compare October 1, 2024 09:20
@0utkarsh 0utkarsh force-pushed the backend/feat/split_settlement branch from e20fe05 to 0f3aa41 Compare October 1, 2024 11:37
@0utkarsh 0utkarsh force-pushed the backend/feat/split_settlement branch from 0f3aa41 to 33a7e43 Compare October 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants