Update libcoap to 4.3.5, bump dependencies, improve linking (incl. ESP32) #93
Annotations
6 errors and 28 warnings
test (libcoap-rs, gnutls)
Process completed with exit code 101.
|
test (libcoap-sys, mbedtls)
Process completed with exit code 101.
|
test (libcoap-rs, tinydtls)
Process completed with exit code 101.
|
coverage (libcoap-rs)
Process completed with exit code 1.
|
test (libcoap-rs, mbedtls)
Process completed with exit code 101.
|
test (libcoap-rs, openssl)
Process completed with exit code 101.
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L18:
libcoap-sys/build.rs#L18
warning: unused import: `std::collections::HashMap`
--> libcoap-sys/build.rs:18:5
|
18 | use std::collections::HashMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L19:
libcoap-sys/build.rs#L19
warning: unused imports: `CStr`, `CString`
--> libcoap-sys/build.rs:19:16
|
19 | use std::ffi::{CStr, CString};
| ^^^^ ^^^^^^^
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L20:
libcoap-sys/build.rs#L20
warning: unused import: `Formatter`
--> libcoap-sys/build.rs:20:23
|
20 | use std::fmt::{Debug, Formatter};
| ^^^^^^^^^
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L83:
libcoap-sys/build.rs#L83
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:83:9
|
83 | unsafe {env::set_var("PATH", embuild_env)};
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L386:
libcoap-sys/build.rs#L386
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:386:9
|
386 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
[clippy (libcoap-rs)] libcoap-sys/build.rs#L507:
libcoap-sys/build.rs#L507
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:507:5
|
507 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
lint (libcoap-rs)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L18:
libcoap-sys/build.rs#L18
warning: unused import: `std::collections::HashMap`
--> libcoap-sys/build.rs:18:5
|
18 | use std::collections::HashMap;
| ^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L19:
libcoap-sys/build.rs#L19
warning: unused imports: `CStr`, `CString`
--> libcoap-sys/build.rs:19:16
|
19 | use std::ffi::{CStr, CString};
| ^^^^ ^^^^^^^
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L20:
libcoap-sys/build.rs#L20
warning: unused import: `Formatter`
--> libcoap-sys/build.rs:20:23
|
20 | use std::fmt::{Debug, Formatter};
| ^^^^^^^^^
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L83:
libcoap-sys/build.rs#L83
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:83:9
|
83 | unsafe {env::set_var("PATH", embuild_env)};
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L386:
libcoap-sys/build.rs#L386
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:386:9
|
386 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L507:
libcoap-sys/build.rs#L507
warning: unnecessary `unsafe` block
--> libcoap-sys/build.rs:507:5
|
507 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L38:
libcoap-sys/build.rs#L38
warning: you seem to be trying to use `match` for an equality check. Consider using `if`
--> libcoap-sys/build.rs:38:9
|
38 | / match name {
39 | | "PACKAGE_VERSION" => {
40 | | let version_str = String::from_utf8_lossy(value);
41 | | println!("cargo:rustc-cfg=libcoap_version=\"{}\"", version_str.as_ref());
... |
49 | | _ => {}
50 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
= note: `#[warn(clippy::single_match)]` on by default
help: try
|
38 ~ if name == "PACKAGE_VERSION" {
39 + let version_str = String::from_utf8_lossy(value);
40 + println!("cargo:rustc-cfg=libcoap_version=\"{}\"", version_str.as_ref());
41 + let version = Version::from(version_str.as_ref()).unwrap();
42 + match version.compare(Version::from("4.3.4").unwrap()) {
43 + Cmp::Lt | Cmp::Eq => println!("cargo:rustc-cfg=inlined_coap_send_rst"),
44 + _ => {}
45 + }
46 + self.version.replace(version.to_string());
47 + }
|
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L323:
libcoap-sys/build.rs#L323
warning: use of `format!` to build up a string from an iterator
--> libcoap-sys/build.rs:323:52
|
323 | ... lib_flags.push_str(lib.link_paths.iter().map(|x| format!("-L{} ", x.display())).collect::<String>().as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: call `fold` instead
--> libcoap-sys/build.rs:323:74
|
323 | ... lib_flags.push_str(lib.link_paths.iter().map(|x| format!("-L{} ", x.display())).collect::<String>().as_str());
| ^^^
help: ... and use the `write!` macro here
--> libcoap-sys/build.rs:323:82
|
323 | ... lib_flags.push_str(lib.link_paths.iter().map(|x| format!("-L{} ", x.display())).collect::<String>().as_str());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
= note: `#[warn(clippy::format_collect)]` on by default
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L325:
libcoap-sys/build.rs#L325
warning: use of `format!` to build up a string from an iterator
--> libcoap-sys/build.rs:325:68
|
325 | ... build_config.env("MbedTLS_CFLAGS", lib.link_paths.iter().map(|x| format!("-I{}", x.display())).collect::<String>());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: call `fold` instead
--> libcoap-sys/build.rs:325:90
|
325 | ... build_config.env("MbedTLS_CFLAGS", lib.link_paths.iter().map(|x| format!("-I{}", x.display())).collect::<String>());
| ^^^
help: ... and use the `write!` macro here
--> libcoap-sys/build.rs:325:98
|
325 | ... build_config.env("MbedTLS_CFLAGS", lib.link_paths.iter().map(|x| format!("-I{}", x.display())).collect::<String>());
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= note: this can be written more efficiently by appending to a `String` directly
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_collect
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L392:
libcoap-sys/build.rs#L392
warning: use of `unwrap_or_else` to construct default value
--> libcoap-sys/build.rs:392:65
|
392 | orig_pkg_config.as_ref().map(String::clone).unwrap_or_else(String::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `#[warn(clippy::unwrap_or_default)]` on by default
|
[clippy (libcoap-sys)] libcoap-sys/build.rs#L392:
libcoap-sys/build.rs#L392
warning: this call to `as_ref.map(...)` does nothing
--> libcoap-sys/build.rs:392:21
|
392 | orig_pkg_config.as_ref().map(String::clone).unwrap_or_else(String::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `orig_pkg_config.clone()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
= note: `#[warn(clippy::useless_asref)]` on by default
|
lint (libcoap-sys)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, giraffate/clippy-action@main. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-sys, gnutls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-rs, gnutls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-sys, mbedtls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-rs, tinydtls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-sys, tinydtls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
coverage (libcoap-rs)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, baptiste0928/cargo-install@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-rs, mbedtls)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-sys, openssl)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
test (libcoap-rs, openssl)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|