Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a unique url for each word #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Set a unique url for each word #10

wants to merge 2 commits into from

Conversation

mmai
Copy link

@mmai mmai commented Jan 23, 2022

This updates the url with a unique hash so we can share words with links like this : https://mmai.github.io/wordlem/#fr-FR/6/AMd

I think this is an interesting feature, but I had to make changes in a lot of places, and I am still discovering elm, so I won't be disapointed if you don't merge this pull request :)

@n1k0
Copy link
Owner

n1k0 commented Jan 23, 2022

Thanks!

I didn't look at the code just yet but trying the feature using the demo link you provided, I'm getting this:

image

Also, on your version, closing the initial Help modal isn't persisted anymore in localStorage, so it shows up every time users refresh the page.

@mmai
Copy link
Author

mmai commented Jan 23, 2022

Ah yes, sorry. It should be fixed in the last commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants