Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iroh-net-report): Support wasm32 building & running #3139

Draft
wants to merge 2 commits into
base: matheus23/iroh-relay-browser
Choose a base branch
from

Conversation

matheus23
Copy link
Contributor

Description

Breaking Changes

Notes & open questions

Change checklist

  • Self-review.
  • Documentation updates following the style guide, if relevant.
  • Tests if relevant.
  • All breaking changes documented.

@matheus23 matheus23 self-assigned this Jan 20, 2025
@matheus23 matheus23 changed the title Matheus23/iroh net report browser feat(iroh-net-report): Support wasm32 building & running Jan 20, 2025
Copy link

github-actions bot commented Jan 20, 2025

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3139/docs/iroh/

Last updated: 2025-01-24T11:12:03Z

Copy link

github-actions bot commented Jan 20, 2025

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: d40c82f

@matheus23 matheus23 force-pushed the matheus23/iroh-net-report-browser branch from 2b9f228 to 942d4ac Compare January 20, 2025 16:41
@matheus23
Copy link
Contributor Author

The only thing that iroh-net-report would be doing in Wasm is running HTTPS probes.
Turns out we don't actually use them in iroh.

I have a browser version of iroh working that doesn't depend on iroh-net-report at all. This makes stuff a lot simpler.

So, I'm going to close this.

@matheus23 matheus23 closed this Jan 24, 2025
@matheus23 matheus23 reopened this Jan 24, 2025
@matheus23 matheus23 changed the base branch from main to matheus23/iroh-relay-browser January 24, 2025 08:35
@matheus23 matheus23 closed this Jan 24, 2025
@matheus23
Copy link
Contributor Author

Hm, what I wrote above is incorrect. We do need the relay latencies to decide which relay to connect to.

@matheus23 matheus23 reopened this Jan 24, 2025
@matheus23 matheus23 force-pushed the matheus23/iroh-net-report-browser branch from 942d4ac to 766164e Compare January 24, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant