Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use configured smarthost for PHP emails #1835

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Conversation

struan
Copy link
Member

@struan struan commented Oct 9, 2024

This updates the utility class to use the configured smarthost, plus adds a port configuration, and then updates docker to use mailhog and configure php to use this. Largely to make testing things like alert signups etc easier in docker.

@struan struan force-pushed the php-use-configured-smarthost branch from f43731c to 12dd9bc Compare October 9, 2024 10:38
@struan struan requested review from dracos and ajparsons October 10, 2024 16:01
Copy link
Member

@dracos dracos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For my reference as much as anything, OPTION_SMTP_SMARTHOST was previously only being used by scripts/ calling EmailUtil::send_email.

@struan struan force-pushed the php-use-configured-smarthost branch from 12dd9bc to 97614fa Compare October 22, 2024 15:20
@struan struan merged commit 97614fa into master Oct 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants