Re-enable popular searches #1820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Explicit number of IP addresses required. - Reduce number of items listed to 5. - Easier to add exclusions. - Support for limiting by section.
ajparsons
force-pushed
the
readd-popular-search
branch
from
26fc3bc to
25edaff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is adding a few more parameters to the recent searches option.
I've added explicitly some things that were loosely managed through the search caching.
Ideally, we'd be able to add exclusions through the admin interface - but this means just adding to an array if we need to make a change.
In the interest of getting it back up - I've stopped halfway through adding it back to the devolved homepages.
There is now support for limiting by section - so Scotland could just show Scottish searches. This works fine - but where it needs more work is pulling out when searches for people are devolved politicians (and given the lower daily search volume) having a more useful full back for the search (I think we could have something configured in the admin - but adding a few new things to the admin felt like pushing the scope too much).