Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage improvements #1818

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Homepage improvements #1818

merged 4 commits into from
Sep 24, 2024

Conversation

lucascumsille
Copy link
Contributor

@lucascumsille lucascumsille commented Sep 12, 2024

Fixes:

The first commit should improve the overlapping of the searchbar on the next element.
I also added some other commits to fix the following:

Spacing problems in the homepage(mobile)
Screenshot 2024-09-12 at 14 39 56

Odd border radius on mobile
Screenshot 2024-09-12 at 14 40 47
Screenshot 2024-09-12 at 14 41 00

Horizontal spacing on mobile not consistent with the rest of the page
Screenshot 2024-09-12 at 14 47 28

Preview

Screen.Recording.2024-09-12.at.14.50.31.mov

@ajparsons
Copy link
Contributor

I think this is all good opening on the test server. I think this can be merged but was possibly draft because I said I wanted to roll some other stuff in Monday.

@lucascumsille
Copy link
Contributor Author

@ajparsons Yes that's why I left it as a draft.

@ajparsons
Copy link
Contributor

Okay, I'm taking too long. let's convert this to a real PR monday but I loaded it and can approve

@lucascumsille lucascumsille marked this pull request as ready for review September 23, 2024 05:53
@lucascumsille
Copy link
Contributor Author

Thanks @ajparsons I just made it a PR =)

@ajparsons ajparsons merged commit a54c617 into master Sep 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants