PHP formatter #1814
Merged
PHP formatter #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajparsons
force-pushed
the
php-formatter
branch
from
d194db8 to
b9b3117
Compare
ajparsons
force-pushed
the
php-formatter
branch
from
b9b3117 to
7d5383b
Compare
|
Now has a rule to put braces on the same line for classes and functions. |
dracos
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds php-cs-fixer as a formatter for php files.
array()vs[]- and we can adjust this as we go into php 8.I've separated the two rules into two commits to show what it's doing at each step. This includes removing older style syntax.
When approved, the last two commits will be undone and rerun on whatever the state of master is at that point. Ideally this is when there are few PHP touching PRs outstanding.