-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display agreements #1762
Display agreements #1762
Conversation
- Agreements live in json and are associated with policies - Don't need a connection to MPs
- Uses date range to only show relevant agreements for an MP
ededb78
to
47239a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny things. Nice to have a way to include these!
Only minor structural thing, and much easier the way you've done it, is that it feels like you'd want to have a Policy object containing its divisions and its agreements together. But I don't suggest trying to rejig everything to enable that :)
Just for revisiting when this isn't fixed in 10 years time - do you mean like a In twfy-votes, there's a PolicyDecisionLink that can be specialised for Divisions or Agreements - the Policy object maintains two lists, but they can be combined easier. So could pull that concept back in at some point. https://github.com/mysociety/twfy-votes/blob/main/src/twfy_votes/apps/policies/models.py#L163-L167 |
Sorry, no, wasn't clear, I didn't mean they'd be together as one list, but that they'd both be under one object for the policy, rather than be in two different things under Policies |
Fixup commit fixes indenting |
This PR adds basic support for displaying agreements in the Policy-for-MP page:
This doesn't directly deal with if agreements score for policies - that can be enabled after #1755 is merged however.