fixup! Improve text for MPs who have lost the whip/switched parties

mysociety · Mar 25, 2024 · d165116 · d165116
1 parent b314bf4
commit d165116
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/www/docs/mp/index.php b/www/docs/mp/index.php
@@ -378,7 +378,7 @@
 $data['unslugified_comparison_party'] = ucwords(str_replace('-', ' ', $data['comparison_party']));
 
 // is the party we're comparing this MP to different from the party they're currently in?
-$data['party_switcher'] = (slugify($data['current_party_comparison']) <> slugify($data["comparison_party"]));
+$data['party_switcher'] = (slugify($data['current_party_comparison']) != slugify($data["comparison_party"]));
 
 // Do any necessary extra work based on the page type, and send for rendering.
 switch ($pagetype) {
@@ -451,7 +451,6 @@ function($k) { return $k['score_difference'] >= 2; }
 
         if ( $policyID ) {
             $data['policydivisions'] = $divisions->getMemberDivisionsForPolicy($policyID);
-            $rel_agreements = $policiesList->all_policy_agreements[$policyID] ?? [];
             $rel_agreements = $MEMBER->member_agreements($policyID, HOUSE_TYPE_COMMONS);
             $data['policyagreements'] = array($policyID => $rel_agreements);
         } else {

diff --git a/www/includes/easyparliament/templates/html/mp/votes.php b/www/includes/easyparliament/templates/html/mp/votes.php
@@ -77,7 +77,6 @@
                 <div class="panel">
                     <a name="votes"></a>
                     <h2><?= $full_name ?>&rsquo;s voting in Parliament</h2>
-                    <?php $unslugified_comparison_party = ucwords(str_replace('-', ' ', $comparison_party)); ?>
 
                     <?php if ($party_switcher == true) { ?>
                         <p>