Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rubocop workflow #121

Merged
merged 3 commits into from
Dec 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ jobs:
fail-fast: false
matrix:
include:
- { ruby: 2.6 }
- { ruby: 2.7 }

steps:
Expand Down
14 changes: 10 additions & 4 deletions .github/workflows/rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,23 @@ on: [pull_request]

jobs:
build:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
env:
BUNDLE_ONLY: rubocop
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 2.6
ruby-version: 2.7

- run: |
gem install securerandom -v 0.3.2
gem install activesupport -v 7.1.5.1

- name: Run RuboCop linter
uses: reviewdog/action-rubocop@v1
uses: reviewdog/action-rubocop@v2
with:
github_token: ${{ secrets.github_token }}
reporter: github-pr-review
Expand Down
2 changes: 1 addition & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ AllCops:
- 'bin/rubocop'
NewCops: enable
SuggestExtensions: false
TargetRubyVersion: 2.6
TargetRubyVersion: 2.7

Metrics/BlockLength:
Exclude:
Expand Down
2 changes: 2 additions & 0 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,9 @@ GEM
zeitwerk (2.4.2)

PLATFORMS
arm64-darwin
ruby
x82_64-darwin

DEPENDENCIES
icasework!
Expand Down
2 changes: 1 addition & 1 deletion icasework.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Gem::Specification.new do |spec|
'organisations of all sizes to do a better job of case management'
spec.homepage = 'https://github.com/mysociety/icasework-ruby/'
spec.license = 'MIT'
spec.required_ruby_version = Gem::Requirement.new('>= 2.6.0')
spec.required_ruby_version = Gem::Requirement.new('>= 2.7.0')

spec.metadata['allowed_push_host'] = 'https://rubygems.org'

Expand Down
Loading