Floating continue #5347
Floating continue #5347
Conversation
| @@ -1641,7 +1530,7 @@ fixmystreet.message_controller = (function() { | |||
| if (typeof stopper.message === 'function') { | |||
| $msg = stopper.message(); | |||
| } else { | |||
| $msg = $('<div class="box-warning">' + stopper.message + '</div>'); | |||
There was a problem hiding this comment.
Removing this box-warning means there's no padding at all on the message which can look odd:
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5347 +/- ##
==========================================
+ Coverage 82.41% 82.49% +0.07%
==========================================
Files 416 416
Lines 32899 32895 -4
Branches 5283 5291 +8
==========================================
+ Hits 27114 27136 +22
+ Misses 4225 4196 -29
- Partials 1560 1563 +3 ☔ View full report in Codecov by Sentry. |
|
For really long extra questions pages that result in a stopper the bottom of the extra form is covered by the floating message (HTML edited for dramatic effect):
|
dracos
force-pushed
the
floating-continue
branch
from
849b649 to
cb3a375
Compare
|
Bromley parks/no parks messaging - works nicely on desktop if switched to new hover message, but doesn't appear at all on mobile (because the map page on which it's shown is never visited again). Think will need to add a new way to immediately show the message on current page hovered, rather than only on map page. Not sure if this applies to anything else. |
|
For contacts with really tall stopper messages (e.g. Surrey) the floating button element blocks the rest of the page:
|
Check the new notification element for containing warning messages to show notificatins are being shown or not and remove the necessity for scrolling down in tests
|
Double-stacked stopper messages can happen and obscure the category list: 
|
|
When making a report, if you get to the 'Your details' view and then move the pin off the required selected asset, error message is not shown. Using Merton parks as an example in screenshots. Issue appears to be that the floating button is not used at this stage. On Merton cobrand, select 'Parks and Recreation Grounds'. Choose a park. Begin report. On 'Your details' view, move the pin out of the park. Current behaviour:
New behaviour:
|
No description provided.