Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use contract start date, not tender start date in templates #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevenday
Copy link

It's already labelled as such in the UI, but we weren't pulling the
right field from the OCDS json to be able to show a contract start date,
instead showing the tender's start date, which can be confusing.
This adds a new field to the model to get the right data from the OCDS
JSON and then shows that instead. I've also added the corresponding
end date field for completeness.

Note that this changes the Postgres view, so we need to run
python manage.py sync_pgviews --force to regenerate them, but this is
contained within script/migrate, so I presume would be run on normal
deployment anyway.

It's already labelled as such in the UI, but we weren't pulling the
right field  from the OCDS json to be able to show a contract start date,
instead showing the tender's start date, which can be confusing.
This adds a new field to the model to get the right data from the OCDS
JSON and then shows that instead.

Note that this changes the Postgres view, so we need to run
`python manage.py sync_pgviews --force` to regenerate them, but this is
contained within script/migrate, so I presume would be run on normal
deployment anyway.
@stevenday
Copy link
Author

stevenday commented Nov 25, 2020

We've been doing some work at Open Ownership to localise the Bluetail prototype for Indonesia and Mexico and we noticed this little bug along the way, so I thought I'd PR it. I'll also share some of the translation stuff we've been doing in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant