Don't build the jupyterlab-jupytext extension if npm is not available #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinRenou
reviewed
Jan 11, 2021
| ) | ||
| cmdclass = {} | ||
|
|
||
| # We can't allow this on the CI, as we publish the package with PyPi-publish |
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
=======================================
Coverage 99.12% 99.12%
=======================================
Files 95 95
Lines 9356 9356
=======================================
Hits 9274 9274
Misses 82 82
Continue to review full report at Codecov.
|
mwouts
force-pushed
the
simply_skip_labextension_if_nodejs_is_missing
branch
from
666d583
to
c3fdea3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May close #706