Add support for go notebooks #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of Jupytext developed in this PR can be installed with (this requires |
mwouts
force-pushed
the
support_gonb
branch
2 times, most recently
from
c933c88
to
37f6d3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
Coverage 97.02% 97.03%
=======================================
Files 29 29
Lines 4468 4479 +11
=======================================
+ Hits 4335 4346 +11
Misses 133 133 ☔ View full report in Codecov by Sentry. |
mwouts
commented
Jul 6, 2024
src/jupytext/cell_reader.py
Outdated
| @@ -555,6 +555,11 @@ def uncomment_code_and_magics(self, lines): | |||
| else: | |||
| lines = uncomment(lines) | |||
|
|
|||
| if self.default_language == "go" and self.language is None: | |||
| lines = [ | |||
| re.sub(r"^([/\s]*)(//\s*gonb:%%)", r"\1%%", line) for line in lines | |||
There was a problem hiding this comment.
We need to escape the %% commands in Markdown cells too, that's why we might find multiple levels of comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1244