Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progressive quality digression to meet max_size requirements. #8

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Progressive quality digression to meet max_size requirements. #8

wants to merge 5 commits into from

Commits on Sep 3, 2014

  1. Added a couple of settings to allow phantomjs to attempt to render im… 

    …ages at lower quality if the output PNG size exceeds a specified limit. Added: max_size - an optional value (in bytes) that will cause a re-try of the render at progressively lower quality until the max_size limit is satisfied. Added: min_quality - an integer value that will provide a lower bound to the attempts at shrinking the PNG size. Added: quality_increment - an integer value representing the quality increment to descend as the program attempts to satisfy the max_size limit. Default is 5. Added: render_timeout - allows user to specify the milliseconds to wait before rendering the page. Default is 200.
    Stuart Young committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    75053ea View commit details
    Browse the repository at this point in the history

  2. Adding some logging to figure out what's going wrong on the dev serve… 

    …r. Maybe I have phantomjs installed wrong?
    Stuart Young committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    280e32a View commit details
    Browse the repository at this point in the history

  3. Adding some logging to figure out what's going wrong on the dev serve… 

    …r. Maybe I have phantomjs installed wrong?
    Stuart Young committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    3b1d4ba View commit details
    Browse the repository at this point in the history

  4. Adding some logging to figure out what's going wrong on the dev serve… 

    …r. Maybe I have phantomjs installed wrong?
    Stuart Young committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    6beacf2 View commit details
    Browse the repository at this point in the history

  5. Removing the logging. The callback is firing. Something is amiss in m… 

    …y grunt script.
    Stuart Young committed Sep 3, 2014
    Configuration menu
    Copy the full SHA
    b2fcd3f View commit details
    Browse the repository at this point in the history