Skip to content

Commit

Permalink
add support for extraEnv
Browse files Browse the repository at this point in the history
  • Loading branch information
edevosc2c committed Oct 29, 2024
1 parent 5f100c0 commit c67c971
Show file tree
Hide file tree
Showing 7 changed files with 19 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/helm-publish-on-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ name: Helm publish on new tag

on:
push:
tags:
- '*'
branches:
- main

jobs:
chart-publish-on-tag:
Expand Down
2 changes: 1 addition & 1 deletion mviewer/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.4.4
version: 0.4.5

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
Expand Down
6 changes: 6 additions & 0 deletions mviewer/ci/all-optional-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ mviewer:
command: ["/bin/sh", "-c", "echo"]
extraVolumes: []
extraVolumeMounts: []
extraEnv:
FOO: "BAR"
persistence:
mviewer_conf:
annotations:
Expand Down Expand Up @@ -72,6 +74,8 @@ elasticsearch:
- linux
podAnnotations:
myapp: mviewer
extraEnv:
FOO: "BAR"
lifecycle:
lifecycle:
postStart:
Expand Down Expand Up @@ -108,6 +112,8 @@ mviewerstudio:
- linux
podAnnotations:
myapp: mviewer
extraEnv:
FOO: "BAR"
lifecycle:
lifecycle:
postStart:
Expand Down
3 changes: 3 additions & 0 deletions mviewer/templates/elasticsearch-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ spec:
value: "-Dlog4j2.formatMsgNoLookups=true -Dlog4j2.disable.jmx=true"
- name: discovery.type
value: "single-node"
{{- with $webapp.extraEnv }}
{{- toYaml . | nindent 10 }}
{{- end }}
volumeMounts:
- name: elasticsearch-data
mountPath: /usr/share/elasticsearch/data
Expand Down
4 changes: 4 additions & 0 deletions mviewer/templates/mviewer-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ spec:
- name: mviewer
image: "{{ $webapp.image.repository }}:{{ $webapp.image.tag }}"
imagePullPolicy: {{ $webapp.image.imagePullPolicy }}
{{- with $webapp.extraEnv }}
env:
{{- toYaml . | nindent 10 }}
{{- end }}
resources:
{{- toYaml $webapp.resources | nindent 10 }}
securityContext:
Expand Down
1 change: 0 additions & 1 deletion mviewer/templates/mviewerstudio-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ spec:
- name: DEFAULT_ORG
value: no_org
{{- with $webapp.extraEnv }}
env:
{{- toYaml . | nindent 10 }}
{{- end }}
resources:
Expand Down
3 changes: 3 additions & 0 deletions mviewer/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ mviewer:
lifecycle: {}
extraVolumes: []
extraVolumeMounts: []
extraEnv: {}
persistence:
mviewer_conf:
annotations:
Expand Down Expand Up @@ -66,6 +67,7 @@ elasticsearch:
tolerations: []
affinity: {}
podAnnotations: {}
extraEnv: {}
persistence:
es_data:
# existingPV: es-data
Expand Down Expand Up @@ -135,6 +137,7 @@ mviewerstudio:
lifecycle: {}
extraVolumes: []
extraVolumeMounts: []
extraEnv: {}
persistence:
mviewerstudio_conf:
annotations:
Expand Down

0 comments on commit c67c971

Please sign in to comment.