This repository has been archived by the owner on May 17, 2024. It is now read-only.
Add Types #33
Merged
Add Types #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
luwes
reviewed
Jul 21, 2023
There was a problem hiding this comment.
Nice! Thank you.
is load() required? the signature should be the same to native video.load()
private destroy should be private #destroy I think but I would leave private methods out.
what benefits do the private types give?
real JS private features can't be called anyway, even in runtime
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Classes/Private_class_fields
|
I added load so it can be given a description that shows in IDE tools. I typed destroy so the IDE properly tells you it's a private method instead of not existing. Without Destroy Marked as Private |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.