[sovereign] Proposed epoch start header with last cross chain hash and request it if missing #6680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r with cross chain hash
| "shouldRequestLastCrossChainHeader", shouldRequestLastCrossChainHeader, | ||
| ) | ||
|
|
||
| return missingHeaderInTracker || missingHeaderInPool |
There was a problem hiding this comment.
Suggested change
| return missingHeaderInTracker || missingHeaderInPool | |
| return shouldRequestLastCrossChainHeader |
| @@ -865,6 +918,11 @@ func (scbp *sovereignChainBlockProcessor) checkExtendedShardHeadersValidity() er | |||
| return nil | |||
| } | |||
|
|
|||
| // we should not have an epoch start block with main chain headers to be processed | |||
| if sovereignChainHeader.IsStartOfEpochBlock() { | |||
There was a problem hiding this comment.
- The comment and the code are not saying the same thing
- It's not clear why you return error, isn't this reverting the epoch change block?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
CreateBlock) containing the epoch start cross chain data(which contains last cross chain notarized data) - the same way shards do it on mainchain.computeAndRequestEpochStartExtendedHeaderIfMissing) to check if the node has (pool or tracker) the proposed epoch start. If missing, it will request it.checkExtendedShardHeadersValidity:-- now only checks extended headers validity for the current block
-- now checks that the epoch start header does not contain extra extended headers to be processed, and returns error otherwise (
ErrReceivedSovereignEpochStartBlockWithExtendedHeaders)Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?