Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/accounts storage iterator #6547

Draft
wants to merge 25 commits into
base: rc/barnard
Choose a base branch
from

Conversation

BeniaminDrasovean
Copy link
Contributor

@BeniaminDrasovean BeniaminDrasovean commented Oct 21, 2024

Reasoning behind the pull request

  • We need a way to retrieve tokens from a data trie in a sequential order, but with the possibility of continuing from a checkpoint if the data trie has lots of leaves, thus iterating all of the leaves in multiple accesses.

Proposed changes

  • Add new API endpoint /address/iterate-keys. This will be a POST request. The request has numKeys, address, and iteratorState. If the iterator state is empty, the iteration will begin from the rootHash. If numKeys is 0, the iteration will stop either when all the leaves have been retrieved or when the request times out.

Testing procedure

  • Benchmark the iteration of the shard 1 system account data trie
  • Normal testing procedure
  • Testing scenarios

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

Copy link

⚠️ No report was generated due to an error or cancellation of the process.
Please checkout gh action logs for details

@BeniaminDrasovean BeniaminDrasovean changed the base branch from rc/v1.7.next1 to rc/barnard January 9, 2025 08:48
BeniaminDrasovean and others added 2 commits January 9, 2025 10:50
…ount-storage-iterator-9jan

Merge rc/barnard in feat/account storage iterator 9jan
Copy link

github-actions bot commented Jan 9, 2025

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: b1a8ac419677db6ebe3de2dbeb1ce547c9a782d7
  • Current Branch: feat/accounts-storage-iterator
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 09012025-092558
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: 42292a0cf31b5fe3e6929c93398d6184e738e808
  • Current Branch: feat/accounts-storage-iterator
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 22012025-102116
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

BeniaminDrasovean and others added 2 commits January 29, 2025 17:50
…ounts-storage-iterator-29jan

Merge rc/barnard in feat/accounts storage iterator 29jan
Copy link

📊 MultiversX Automated Test Report: View Report

🔄 Build Details:

  • mx-chain-go Commit Hash: e71d7bd3f549faf5e629f1166c675d1be1063287
  • Current Branch: feat/accounts-storage-iterator
  • mx-chain-go Target Branch: rc/barnard
  • mx-chain-simulator-go Target Branch: rc/barnard
  • mx-chain-testing-suite Target Branch: rc/barnard

🚀 Environment Variables:

  • TIMESTAMP: 29012025-163142
  • PYTEST_EXIT_CODE: 1
    🎉 MultiversX CI/CD Workflow Complete!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant