Feat/trie mutex refactor #6076
Draft
Feat/trie mutex refactor #6076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batch trie changes
add unit tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc/v1.7.next1 #6076 +/- ##
=================================================
- Coverage 79.93% 78.80% -1.13%
=================================================
Files 731 754 +23
Lines 96343 98128 +1785
=================================================
+ Hits 77008 77334 +326
- Misses 13934 15563 +1629
+ Partials 5401 5231 -170 ☔ View full report in Codecov by Sentry. |
update trie from batch tests
remove mutex from trie operations
add concurrency unit tests
refactor trie root hash computation
use goroutines manager for trie commit
…d-in-feat/trie-mutex-refactor-16jan # Conflicts: # common/interface.go # state/accountsDB.go # testscommon/trie/trieStub.go # trie/depthFirstSync_test.go # trie/doubleListSync_test.go # trie/extensionNode_test.go # trie/patriciaMerkleTrie_test.go
…e-mutex-refactor-16jan Merge rc/barnard in feat/trie mutex refactor 16jan
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
remove unnecessary trie node encode operations and remove unused code
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
refactor trie constructor
|
📊 MultiversX Automated Test Report: View Report 🔄 Build Details:
🚀 Environment Variables:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning behind the pull request
Proposed changes
Testing procedure
Pre-requisites
Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:
featbranch created?featbranch merging, do all satellite projects have a proper tag insidego.mod?