Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix download button. #340

Merged
merged 6 commits into from
Nov 17, 2024
Merged

Conversation

amin-xiv
Copy link
Contributor

Description

Fixed download button not working in the main page.

Related Issue

Fixes #338

Type of change

  • Bug fix
  • New feature

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for multiverse-dataverse ready!

Name Link
🔨 Latest commit 054cce4
🔍 Latest deploy log https://app.netlify.com/sites/multiverse-dataverse/deploys/67386a9f4f29d90008e8214b
😎 Deploy Preview https://deploy-preview-340--multiverse-dataverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from team will review it as soon as possible. We appreciate your support in making Dataverse better.

@multiverseweb
Copy link
Owner

Hey @amin-xiv, I think the issue isn't solved in this PR. But I know the reason why its happening. The image with opacity set to 0 covers the button. When someone scrolls a little bit, the image shifts downwards and then the button works fine. So you can solve this by increasing the z-index of the button (it should be above the image). Here's the video:

Screen.Recording.2024-11-13.165219.mp4

@amin-xiv
Copy link
Contributor Author

@multiverseweb Ok I'll try my best.

@amin-xiv
Copy link
Contributor Author

@multiverseweb I have increased the z-index of the button, and the problem you said yesterday about if you scroll up the button won't work and if you scroll down, it will, doesn't happen to me locally nor in deploy preview. What do you think?

@multiverseweb
Copy link
Owner

@amin-xiv you're right. I'm unable to understand what the issue is too.
I'll look into it again and will let you know how it can be solved.

@multiverseweb multiverseweb merged commit 97345c8 into multiverseweb:main Nov 17, 2024
5 checks passed
Copy link
Contributor

🎉🎉 Thank you for your contribution! Your PR #340 has been merged! 🎉🎉

@amin-xiv amin-xiv deleted the download-button-fix branch November 17, 2024 15:36
@amin-xiv amin-xiv restored the download-button-fix branch November 17, 2024 15:36
@amin-xiv amin-xiv deleted the download-button-fix branch November 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Website] "Get Dataverse" Button not working.
2 participants