-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented Error Handling and Data Validation in Python Files #201 #213
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for multiverse-dataverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer from Dataverse
team will review it as soon as possible. We appreciate your support in making this project better
@Anushka-Pote Resolve all conflicts. |
Yeah, I got the conflicts, as there was another linear regression model merge made but, before making the PR I resolved all the the conflicts after sync on my local machine itself. You can see it as one of the 5 commits. |
Have I resolved the conflicts or any other change is expected? |
@Anushka-Pote I'm testing the PR, will get back to you soon. |
Heyy |
@Anushka-Pote There are conflicts. So you need to resolve it. |
There were conflicts before i agree, but then I had resolved all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anushka-Pote, there are some problems in this PR:
- You have removed the variable
z
which counts the number of failed login attempts so the code is throwing an error in the terminal in that scenario
Add an error message for
invalid login attempts
. Leave the variablez
as it is, I'll later add a feature that disablesfinance tracker
for some time after2 invalid login attempts
- The colors of pie chart are not same as those used in the line chart.
This can be solved by adding
colors=colors[1:len(columns) + 1]
attribute here
Kindly solve the stated problems to get the PR merged.
Note
I understand that I'm late in reviewing the code and its the last day of GSSoC, so I'll be merging the PR whether you resolve the stated problems timely or not. Will fix them myself otherwise.
Good luck!
Hey I just saw the message right now, And I don't think it will be done by 7 pm to be honest |
Hey @Anushka-Pote no problem. Just let me know if you can still work on this PR otherwise I can fix the problems too |
Description
Enhance the robustness of the Python files in the project by implementing comprehensive error handling and data validation mechanisms. This will ensure the application can handle unexpected scenarios gracefully and provide meaningful feedback to the user.
Related Issue
Fixes #201
Type of change
Checklist