Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remove jogging API #116

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WIP: remove jogging API #116

wants to merge 1 commit into from

Conversation

cielavenir
Copy link
Contributor

because it was removed from planningcommon

@ziyan ziyan requested review from felixvd and ziyan July 1, 2022 02:31
@ziyan ziyan removed their assignment Jul 1, 2022
@felixvd
Copy link
Contributor

felixvd commented Jul 6, 2022

Please bump the version and update CHANGELOG.md. This deprecation is sudden enough, let's at least document it.

Copy link
Contributor

@felixvd felixvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the version and add to CHANGELOG.md e.g.:

# 0.16.0 (2022-10-07)

- Remove jogging API (`SetJogModeVelocities`, `EndJogMode`).

@cielavenir
Copy link
Contributor Author

after discussing with @kanbouchou, we will recover EndJogMode. please wait until things settle

@cielavenir cielavenir changed the title remove jogging API WIP: remove jogging API Oct 8, 2022
felixvd pushed a commit that referenced this pull request Mar 21, 2023
added maxPossibleSizePadding in registerMinViableRegion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants