-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split PDFRip into multiple crates #26
Conversation
Eh whatever, I had a bit of extra time. |
I am removing the workflow from this PR since I add one in #27 anyways |
This looks well organized now, nice! Thank you so much for the effort you're putting into this project @Pommaq, I really appreciate it! 🙌 |
This is a suggestion for how #23 can be performed, additionally I added a few tests and some code cleanup.
It also partially splits all CLI interaction away from main.rs and into a separate crate as suggested by me in #18, the only part left would be to move the ProgressBar away from engine.rs and into cli-interaction as well somehow.
One way would be to allow engine.rs to take a callback which in the case of ProgressBar would simply increment the bar,
then wrap engine::crack_file with something like