Merge pull request #14 from wing5wong/master

fix value error when request payload is empty, but content type is xml
mtownsend5512 · Oct 21, 2024 · 5ed7852 · 5ed7852
2 parents 1387d35 + 65d5d22
commit 5ed7852
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/Providers/RequestXmlServiceProvider.php b/src/Providers/RequestXmlServiceProvider.php
@@ -69,7 +69,7 @@ protected function registerIsXml()
     protected function registerXml()
     {
         Request::macro('xml', function () {
-            if (!$this->isXml()) {
+            if (!$this->isXml() || empty($this->getContent())) {
                 return [];
             }
             try {

diff --git a/tests/RequestXmlTest.php b/tests/RequestXmlTest.php
@@ -83,4 +83,12 @@ public function request_can_parse_xml_as_a_valid_array()
         $request = $this->createDummyRequest(['CONTENT_TYPE' => 'application/xml'], $this->testXml);
         $this->assertEquals($request->xml(), $this->testArray);
     }
+
+    /** @test */
+    public function request_with_xml_content_type_and_empty_payload()
+    {
+        $request = $this->createDummyRequest(['CONTENT_TYPE' => 'application/xml']);
+        $this->assertEquals($request->xml(), []);
+        $this->assertTrue($request->isXml());
+    }
 }