get metatable proxying of attached players table working

doc/player.md

@@ -0,0 +1,12 @@
+# Player API
+
+mimic mtg player_api
+
+## NOTE
+
+`xcompat.player.player_attached`
+
+read/write from it is fine, looping over it is not as it is a proxy table. s
+would need lua5.2 __pairs/__ipairs metamethods support which i could polyfill
+for using https://stackoverflow.com/a/77354254 but didnt feel like doing at 
+this time

src/player/mineclonia.lua

@@ -24,6 +24,17 @@ function papi.set_animation(player, anim_name, speed)
     return mcl_player.player_set_animation(player, anim_name, speed)
 end
 
---todo: handle ignoring animations (maybe metatables?)
+local metatable = {
+    __index = function (_, key)
+        return mcl_player.player_attached[key]
+    end,
+    __newindex = function (_, key, value)
+        rawset(mcl_player.player_attached, key, value)
+    end
+}
+
+papi.player_attached = {}
+
+setmetatable(papi.player_attached, metatable)
 
 return papi

src/player/minetest.lua

@@ -25,27 +25,17 @@ function papi.set_animation(player, anim_name, speed, loop)
 end
 
 
-local papi_metatable = {
-    __newindex = function (table, key, value)
-        player_api.player_attached[key] = value
-
-        rawset(table, key, value)
-    end
-}
-
-local player_api_metatable = {
-    __newindex = function (table, key, value)
-        rawset(papi.player_attached, key, value)
-        rawset(table, key, value)
+local metatable = {
+    __index = function (_, key)
+        return player_api.player_attached[key]
+    end,
+    __newindex = function (_, key, value)
+        rawset(player_api.player_attached, key, value)
     end
 }
 
 papi.player_attached = {}
 
---when a value is set in xcompat api, this will also set it in the player api
-setmetatable(papi.player_attached, papi_metatable)
-
---when a value is set in player api, this will also set it in the xcompat api
-setmetatable(player_api.player_attached, player_api_metatable)
+setmetatable(papi.player_attached, metatable)
 
 return papi