Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use moreores tin when moreores and mcl_core are detected #383

Merged
merged 1 commit into from
Sep 28, 2024

Conversation

programmerjake
Copy link
Contributor

Fixes: #381

@OgelGames
Copy link
Contributor

We really should switch to using xcompat, but I see no reason not to add this small change in the meantime 👍

OgelGames
OgelGames previously approved these changes Sep 28, 2024
@OgelGames
Copy link
Contributor

Actually now that I look a bit closer, you should add the changes to lines 17 and 18, like this:

	tin_ingot = has_moreores and "moreores:tin_ingot" or has_mcl and "mcl_core:iron_ingot" or "default:tin_ingot",
	tin_lump = has_moreores and "moreores:tin_lump" or has_mcl and "mcl_raw_ores:raw_iron" or "default:tin_lump",

@programmerjake
Copy link
Contributor Author

Actually now that I look a bit closer, you should add the changes to lines 17 and 18, like this:

	tin_ingot = has_moreores and "moreores:tin_ingot" or has_mcl and "mcl_core:iron_ingot" or "default:tin_ingot",
	tin_lump = has_moreores and "moreores:tin_lump" or has_mcl and "mcl_raw_ores:raw_iron" or "default:tin_lump",

no, because you need default:tin_* even if you have moreores. so I thought that would make the boolean expression too complex, so I used a much easier to understand if

@programmerjake
Copy link
Contributor Author

  without moreores with moreores
minetest game default's tin default's tin
mineclone* mineclone's iron moreores's tin

@OgelGames
Copy link
Contributor

Oh, right... because moreores doesn't register its tin when default tin is available 🤦

@OgelGames OgelGames merged commit 32f1d5a into mt-mods:master Sep 28, 2024
3 checks passed
@programmerjake programmerjake deleted the use_moreores_in_mineclone branch September 28, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use moreores tin/silver/mithril when in mineclone* game
2 participants