-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge concrete into technic_worldgen
and extranodes
#322
Conversation
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.36% in 11/14 files:
Test coverage report for technic chests 45.49% in 6/6 files:
Test coverage report for technic 66.03% in 96/96 files:
Raw test runner output for geeks:CNC:
Chests:
Technic:
|
Best would be to move Technic nuclear reactor, radiation stuff and probably brc into its own mod. (and yes, centrifuges too but not into same mod) That atm would probably however be way too much to change at once while just moving materials to worldgen is fairly simple thing to do. Didn't read all of it but will decorative concrete extra stuff be configurable so that it is not hard requirement for anything? |
(didn't test but looks good and i trust the ✔️ icon near the commit) |
Btw one additional mineunit test seems been added here |
I'm pretty sure that's the BRC added to |
As per discussion in #144, merges the
concrete
mod intotechnic_worldgen
(blast-resistant concrete block) andextranodes
(stairs and stuff made from concrete). Mostly just a cut and paste job, cleanup can be done in other PRs.Closes #144