Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make dp_modpack game agnostic using XCompat #14

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Make dp_modpack game agnostic using XCompat #14

merged 2 commits into from
Mar 11, 2024

Conversation

Niklp09
Copy link
Member

@Niklp09 Niklp09 commented Mar 8, 2024 •
edited
Loading

Closes #13

  • Remove mtg specific formspec stuff
  • Switch to game agnostic crafting ingredients
  • Switch to game agnostic sounds
  • Use game agnostic wood textures

TBD:

image

@Niklp09 Niklp09 added the enhancement New feature or request label Mar 8, 2024
@Niklp09 Niklp09 marked this pull request as ready for review March 8, 2024 15:57
@wsor4035 wsor4035 mentioned this pull request Mar 11, 2024
Merged
wsor4035
wsor4035 approved these changes Mar 11, 2024
View reviewed changes
Copy link

@wsor4035 wsor4035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: i did not test this

pending the tbd section being done/merged, looking over the code this looks good/makes sense

@Niklp09 Niklp09 merged commit c315900 into master Mar 11, 2024
2 checks passed
@Niklp09 Niklp09 deleted the xcompat branch March 11, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wsor4035 wsor4035 wsor4035 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port material and sound usage to XCompat
2 participants
@Niklp09 @wsor4035