Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sort read_group and fastq_pair_id values before concatenation #137

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

anoronh4
Copy link
Collaborator

@anoronh4 anoronh4 commented Jan 30, 2025

Addresses #135

sorts read_group and fastq_pair_id values before concatenation so that the values are consistent across read groups and fastq origins for a sample, and also reproducible between resumed runs.

I am not adding tests in this PR because I am working on another branch to upgrade the tests.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the mskcc/forte branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants