-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch generic apis #312
Open
GaPhi
wants to merge
48
commits into
mseminatore:master
Choose a base branch
from
GaPhi:patch-generic-apis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch generic apis #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider username/password as access/refresh tokens when username does not include '@' (email address)
See https://tesla-api.timdorr.com/api-basics/vehicles#get-api-1-vehicles-id Adding this and deploying it to apiary will unblock adding support for this endpoint to TeslaJS
These functions use `options.vehicleID` to make a call to fetch a specific Vehicle from the Tesla API, rather than fetching all vehicles and using `carIndex` to select the requested vehicle. Fixes mseminatore#273
Add sync & async calls to SetChargingAmps API
Add setScheduledCharging calls API
Add setScheduledDeparture API calls
- setChargingAmps - setScheduledCharging - setScheduledDeparture
NPM package with @GaPhi scope
Scheduled times can be any value in minutes since midnight local time, even if Tesla apps do not propose it.
windowControl needs lat/lon for the 'close' command. NB: Cannot test it on my car, maybe a GET request is required rather than POST? Fix a typo too
This is probably a small copy paste mistake from steeringHeater function above.
Fix typo in maxDefrost function name
Add vehicleById and vehicleByIdAsync function
Add "/api/1/vehicles" to API blueprint
Redirect to registered region
Bumps [ws](https://github.com/websockets/ws) from 8.2.2 to 8.3.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.2.2...8.3.0) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This argument is : - true if (preconditioning_enabled or off_peak_charging_enabled) - false otherwise NB: this condition may change in the future
Sync with parent branch
Bumps [ws](https://github.com/websockets/ws) from 8.2.2 to 8.3.0. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.2.2...8.3.0) --- updated-dependencies: - dependency-name: ws dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bump ws from 8.2.2 to 8.3.0
- windowControl need lat/lon for close command - remoteStart does not need password anymore
Add endpoints and let_sleep parameters to vehicleData command
Use an "args" object for all commands Add query string capability to GET or POST commands
Add endpoints and let_sleep parameters to vehicleData command
GaPhi
commented
Feb 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing tests or docs should be ok now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #311.
Changes proposed in this pull request:
This could break a little the compatibility with previous version (then tag 4.11.0 proposed) but should not be the case anymore for future versions.