Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in error reporting #120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions test/test-jquery-integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,24 @@
$.pubsub( 'publishSync', topic, data );

assert( mock.verify() );
},

"$.pubsub() reports errors to the console when one is available" : function(){
var mock = this.mock( global.console );
mock.expects( 'error' ).once().withArgs( new Error('Method bogus does not exist on jQuery.pubsub') );
$.pubsub( 'bogus' );
},

"$.pubsub() reports errors with jQuery when the console is not available" : function(){
var nativeConsole = global.console;
try {
var mock = this.mock( $ );
global.console = undefined;
mock.expects( 'error' ).once().withArgs( 'Method bogus does not exist on jQuery.pubsub' );
$.pubsub( 'bogus' );
} finally {
global.console = nativeConsole;
}
}
});
}(this));
2 changes: 1 addition & 1 deletion wrappers/jquery/pubsub.js.post.txt
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@

function reportError(message) {
function reportError(errorMessage) {
if (typeof console !== 'undefined'){
console.error(new Error(errorMessage));
return;
Expand Down