Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make deletion of all photos more robust, and a few other contributions merged #54

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Make deletion of all photos more robust, and a few other contributions merged #54

wants to merge 15 commits into from

Conversation

lcorbasson
Copy link

This PR builds upon previous contributions:

and improves them a bit by:

  • allowing the user to select how many items should be deleted and which kind of items through the called function's arguments,
  • fixing the issue with huge sets (thousands of pictures) where the wait time for new checkboxes to re-appear can be quite long, and you'll need to sleep and retry.

This still needs some formatting and documentation to be improved.

gpmidi and others added 15 commits June 22, 2023 11:48
@gpmidi
Update delete_photos.js
3a5f4d2 
Added an extra pause for page loads - helps with HUGE libraries. 
Added a comment regarding an option that can help with premature stops on some big libraries.
@gpmidi
Update delete_photos.js
913941c 
Added option as default to select by day rather than small sets at a time. Offers as massive speed up for big sets. Stolen from mrishab#43.
@gpmidi
Update delete_photos.js
55e703a 
Fixing some logging verbage
@gpmidi
Update delete_photos.js
3fa3260 
Changed default checkboxClass back to one at a time. Updated the comment to indicate that it won't delete single-image dates.
@gpmidi
Wrapping in easy function to rerun
4d9c52f 
Wrapped in an easy to rerun function that avoids duplicate deceleration errors.
@lcorbasson
Merge pull request #1 from gpmidi/patch-1
2cdf65a 
gpmidi:patch-1
@lcorbasson
Move maxImageCount to a function argument
9dc4895
@lcorbasson
Change function name to more explicit deleteGooglePhotos()
6d01235
@lcorbasson
Better (and longer) retries when no checkboxes found
63c6e3a
@lcorbasson
Log checkbox searches to the console
6489a6c
@lcorbasson
Add an infinity mode
a8eaf44
@lcorbasson
Default to infinity mode
15c3fe8
@lcorbasson
Use async/await to make sleep() work
2a0fc47
@lcorbasson
Fix typo
4714bd7
@lcorbasson
Default back to "photos" deletion, now that sleep() works and checkbo…
522cff4 
…x search retries do too
@lcorbasson
Copy link
Author

Note that this was successfully tested on a set of 96,000 photos using Chromium 114 on Debian GNU/Linux "bookworm".

@gpmidi gpmidi mentioned this pull request Jul 20, 2023
Open
@mrishab
Copy link
Owner

mrishab commented Sep 8, 2024

Please resolve conflicts and reduce diff for comprehension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcorbasson @mrishab @gpmidi