options.c cleanup #15313
Open
options.c cleanup #15313
+123
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use sub-filter common prefix.
Move them to a suboption so the suboption prefix can be used.
|
Download the artifacts for this pull request: |
llyyr
reviewed
Nov 14, 2024
| @@ -67,6 +67,29 @@ struct seen_packet { | |||
| double pts; | |||
| }; | |||
|
|
|||
| #undef OPT_BASE_STRUCT | |||
There was a problem hiding this comment.
Should be in filter_sdh.c, not here.
There was a problem hiding this comment.
mp_sub_filter_opts is used in sd_ass.c, not in filter_sdh.c.
Line 184 in 70aaba7
The options and struct are only used in stream_dvdnav.c. Also use dvd prefix for dvd_conf.
na-na-hi
force-pushed
the
opts-cleanup
branch
from
264952f
to
40ae2fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move several option definitions to the respective modules and use common prefix if possible.