Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defaults.js: fix the opened event with mp.input.get #15302

Merged
merged 2 commits into from
Nov 14, 2024
Merged

defaults.js: fix the opened event with mp.input.get #15302

merged 2 commits into from
Nov 14, 2024

Commits on Nov 13, 2024

  1. defaults.js: fix the opened event with mp.input.get 

    The opened event doesn't send any arguments. Don't call
JSON.parse(undefined) in that case because it errors.

Fixes eb4c6be, fixes mpv-player#15301.
    @guidocella
    guidocella committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    94073d6 View commit details
    Browse the repository at this point in the history

  2. defaults.js: send the right number of arguments to input.get callbacks 

    Only send how many arguments were actually passed by console.lua instead
of sending extra undefined arguments.
    @guidocella
    guidocella committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    bf83870 View commit details
    Browse the repository at this point in the history