audio: add a pitch-shifting feature #11214
Conversation
myQwil
force-pushed
the
pitch_shift
branch
3 times, most recently
from
7e5e9e6
to
2b448fb
Compare
myQwil
force-pushed
the
pitch_shift
branch
2 times, most recently
from
f0d6eea
to
74a2d95
Compare
|
Needs rebase and interface changes update. |
myQwil
force-pushed
the
pitch_shift
branch
2 times, most recently
from
d52cd77
to
7c4b471
Compare
|
Download the artifacts for this pull request: |
|
I would prefer to keep changing the speed with {} as it's way more useful than changing pitch. |
|
Yeah I think this is too niche to have a default keybind, users can configure it themselves if they want this feature |
myQwil
force-pushed
the
pitch_shift
branch
2 times, most recently
from
9fdd0b4
to
64729be
Compare
|
keybinding changes have been taken out |
player/audio.c
Outdated
| double drop = 1.0; | ||
|
|
||
| if (!mpctx->opts->pitch_correction) { | ||
| resample *= speed; | ||
| speed = 1.0; | ||
| } | ||
|
|
||
| speed /= mpctx->opts->playback_pitch; | ||
|
|
||
| if (mpctx->display_sync_active) { |
There was a problem hiding this comment.
Is this expected this new feature will not work correctly with -adrop and -tempo sync modes?
There was a problem hiding this comment.
I think this is to be expected.
-tempo prevents resampling and forces the pitch to be corrected.
-adrop prevents both resampling and the time-stretcher.
EDIT: actually, for -adrop, we could probably add something like this:
- drop *= speed * resample;
- resample = speed = 1.0;
+ drop *= speed * mpctx->speed_factor_a;
+ resample = mpctx->opts->playback_pitch;
+ speed = 1.0;
myQwil
force-pushed
the
pitch_shift
branch
6 times, most recently
from
5e34c09
to
67a07dd
Compare
|
Just last thing is missing, note in |
player/audio.c
Outdated
| break; | ||
| default: goto normal; |
There was a problem hiding this comment.
I don't like this goto here. How about
int video_sync = mpctx->display_sync_active ? mpctx->video_out->opts->video_sync : VS_NONE;
switch (video_sync) {
...and put
resample *= pitch;
speed /= pitch;into default case.
Uses resampling in tandem with a time-stretching audio filter to change the audio's pitch while leaving its tempo intact.
myQwil
changed the title
Uses resampling in tandem with any time-stretching audio filter (scaletempo, scaletempo2, rubberband) to change the audio's pitch while leaving its tempo intact.