Update burnham sensors (#1427)

* Update minimum count of rows for burnham sensors * Add code comments to burnham sensors
mozilla · Nov 25, 2021 · 61376a6 · 61376a6
1 parent 5f20d3d
commit 61376a6
Showing 1 changed file with 20 additions and 2 deletions.
diff --git a/dags/burnham.py b/dags/burnham.py
@@ -718,6 +718,12 @@ def sleep_task(minutes, task_id):
         sql=SENSOR_TEMPLATE.format(
             project_id=PROJECT_ID,
             table="discovery_v1",
+            # client1 sends 2 discovery pings
+            # client2 sends 6 discovery pings
+            # client3 sends 2 discovery pings
+            # client5 sends 2 discovery pings
+            # client6 sends 6 discovery pings
+            # client7 sends 2 discovery pings
             min_count_rows=20,
             start_timestamp=start_timestamp,
             test_run=burnham_test_run,
@@ -776,7 +782,9 @@ def sleep_task(minutes, task_id):
         sql=SENSOR_TEMPLATE.format(
             project_id=PROJECT_ID,
             table="starbase46_v1",
-            min_count_rows=1,
+            # client2 sends 1 starbase46 ping
+            # client6 sends 1 starbase46 ping
+            min_count_rows=2,
             start_timestamp=start_timestamp,
             test_run=burnham_test_run,
             test_name=DEFAULT_TEST_NAME,
@@ -819,7 +827,13 @@ def sleep_task(minutes, task_id):
         sql=SENSOR_TEMPLATE.format(
             project_id=PROJECT_ID,
             table="space_ship_ready_v1",
-            min_count_rows=5,
+            # client1 sends 1 space_ship_ready ping
+            # client2 sends 1 space_ship_ready ping
+            # client3 sends 1 space_ship_ready ping
+            # client5 sends 1 space_ship_ready ping
+            # client6 sends 1 space_ship_ready ping
+            # client7 sends 1 space_ship_ready ping
+            min_count_rows=6,
             start_timestamp=start_timestamp,
             test_run=burnham_test_run,
             test_name=DEFAULT_TEST_NAME,
@@ -861,6 +875,8 @@ def sleep_task(minutes, task_id):
         sql=SENSOR_TEMPLATE.format(
             project_id=PROJECT_ID,
             table="discovery_v1",
+            # client4 sends 3 discovery pings
+            # client8 sends 3 discovery pings
             min_count_rows=6,
             start_timestamp=start_timestamp,
             test_run=burnham_test_run,
@@ -904,6 +920,8 @@ def sleep_task(minutes, task_id):
         sql=SENSOR_TEMPLATE.format(
             project_id=PROJECT_ID,
             table="deletion_request_v1",
+            # client4 sends 1 deletion_request ping
+            # client8 sends 1 deletion_request ping
             min_count_rows=2,
             start_timestamp=start_timestamp,
             test_run=burnham_test_run,