-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cipher_Suites table to v5.x #296
Open
janbrasna
wants to merge
17
commits into
mozilla:gh-pages
Choose a base branch
from
janbrasna:fix/cipher-suites-tables
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding back link removed during v4-v5 simplification & archiving.
This was referenced Mar 14, 2024
The table is also being referenced from MDN e.g. https://developer.mozilla.org/en-US/docs/Web/Security/Transport_Layer_Security via the main wiki page, so the link should be there visible, somewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247, #292, april/tls-table#4
Since the simplification after v4.0 and the archival of older more expansive docs aligned with v5.0 guidelines, the link to
Cipher_Suites
was lost, and later the table became outdated, with the tool to help gather the cipher lists from source not able to automate the parsing anymore.Nonetheless the page is still linked from outside, and as a part of the recommendations should be kept up-to-date, even if it means manually for now.
There are two major signs the Cipher_Suites page should not be considered abandoned:
*/Archive/*
and with no deprecation warning in the page intro, so there's no indication it should be interpreted as unmaintained.Cipher_Suites.mediawiki
page is kept here in master meaning it should still be considered part of the current docs, and kept in sync with the guidelines.This PR makes the table useful again by:
<pre/>
instead of<source/>
…)This is how the render looks like: