Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 cipher to intermediate configuration #291

Conversation

gene1wood
Copy link
Collaborator

This adds the TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 / DHE-RSA-CHACHA20-POLY1305 cipher to the end of the intermediate cipher list.

See the related PR mozilla/ssl-config-generator#204

Fixes #285

…configuration

This adds the `TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256` / `DHE-RSA-CHACHA20-POLY1305` cipher to the end of the intermediate cipher list.

See the related PR mozilla/ssl-config-generator#204

Fixes mozilla#285
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conditional on updating the links, this LGTM

@@ -202,6 +206,14 @@ This configuration is compatible with a number of very old clients, and should b
! Editor
! Changes
|-
| style="text-align: center;" | 5.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up on line 198 and 200, you need to update the JSON file link from 5.6 to 5.7.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this but forgot to commit it so it's in #293

@@ -1,6 +1,9 @@
= Cipher suite correspondence table =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This table is apparently generated. I ran the script and it seemed to fail spectacularly, so maybe don't worry about that. I was hoping that it wouldn't be bitrotten, but I don't think that it's worth fixing right now (there are too many things broken).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good point, I didn't notice the reference to https://github.com/april/tls-table/blob/master/tls-table.py

I'll open an issue about it and we can ignore it for now.

Copy link

@janbrasna janbrasna Dec 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this manually! It's been stale for the last couple revisions, see #247

I'll try to update it in a PR to match the current configurations as it is completely outdated just glancing at the colors;)

@gene1wood gene1wood merged commit 6a47475 into mozilla:gh-pages May 16, 2023
@gene1wood gene1wood deleted the add_TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256 branch May 16, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256
3 participants