This repository has been archived by the owner on Jun 29, 2018. It is now read-only.
[#890556] Fix videoHTMLContainer so it does not break player unit tests #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -427,7 +427,7 @@ | |||
| videoHTML += '<source src="' + src[ i ] + '">'; | |||
| } | |||
| videoHTML += "</video>"; | |||
| videoHTMLContainer.innerHTML = videoHTML; | |||
| videoHTMLContainer.outerHTML = videoHTML; | |||
There was a problem hiding this comment.
This isn't an ideal solution for changing the tests. What we basically did here was change the functionality to put the generated video element inside a wrapper and have that wrapping element appending to the target element given.
The tests fail because the video element isn't a direct child of the target element anymore. The correct solution to this is to simply update the tests to correct that expectation.
|
This has moved over to pull request #403 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.