This repository has been archived by the owner on Jun 29, 2018. It is now read-only.
[#963724] Ensure other youtube scripts don't clobber our ready events. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| protocol = window.location.protocol === "file:" ? "http:" : ""; | ||
| // Wait for the script to be loaded, then check if it's ready. | ||
| tag.addEventListener( "load", onYouTubeIframeAPIReady, false); | ||
| tag.src = protocol + "//www.youtube.com/iframe_api"; |
There was a problem hiding this comment.
Instead of having it be http: or https:, can you just force it to https: ?
There was a problem hiding this comment.
Why?
I think there was a time where it needed to work in file:// too...
There was a problem hiding this comment.
If you set it to https: then we don't need to worry about loading it from file:// ever.
It also means I can just close https://bugzilla.mozilla.org/show_bug.cgi?id=965045
…ng for YT.loaded.
| callback(); | ||
| } | ||
| } else { | ||
| setTimeout( onYouTubeIframeAPIReady, 1000 ); |
There was a problem hiding this comment.
The script file loads in about 68ms from the office, so I think it might make sense to lower this? maybe to 250ms?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.