Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task(recovery-phone): Add lookup data to registered numbers #18167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

task(recovery-phone): Add lookup data to registered numbers #18167

wants to merge 1 commit into from
+85 −23

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Dec 23, 2024 •
edited
Loading

Because

  • Lookup data has extra info that could be helpful down the road. e.g Info about sim swapping.

This pull request

  • Calls the Twilio API to get lookup data
  • Stores data in DB

Issue that this pull request solves

Closes: FXA-10727

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner December 23, 2024 20:57
@dschom dschom marked this pull request as draft December 23, 2024 20:57
@dschom dschom changed the title wip task(recovery-phone): Add lookup data to registered numbers Dec 23, 2024
@dschom dschom marked this pull request as ready for review December 23, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dschom