task(auth): Add environment to totp service name #18165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenba
reviewed
Dec 23, 2024
| @@ -173,7 +173,8 @@ module.exports = function ( | |||
| customs, | |||
| config.totp, | |||
| glean, | |||
| profile | |||
| profile, | |||
| config.sentry.env | |||
There was a problem hiding this comment.
It's the most reliable. You can't use NODE_ENV, cause it's production on stage and production...
There was a problem hiding this comment.
I see. Maybe update the comment for that config?
chenba
reviewed
Dec 23, 2024
chenba
approved these changes
Dec 23, 2024
dschom
force-pushed
the
FXA-10834
branch
2 times, most recently
from
e72f1e9 to
073212d
Compare
Because: - We want to be able to distinguish totp entries This Commit: - Append the environment name to the service provided to authenticator.keyuri
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
authenticator.keyuriIssue that this pull request solves
Closes: FXA-10834
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.