Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(next): display correct list amount #18163

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(next): display correct list amount #18163

wants to merge 1 commit into from
+34 −19

Conversation

StaberindeZA
Copy link
Contributor

@StaberindeZA StaberindeZA commented Dec 20, 2024 •
edited
Loading

Because

  • List amount should not include exclusive tax.

This pull request

  • Changes list amount to invoice.subtotal in DTO, to support inclusive and exclusive tax amounts.
  • Adds currency to invoice preview
  • Explicitly set a default currency to USD as a temporary solution.

Issue that this pull request solves

Closes: #FXA-10899

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Exclusive Tax

image

image

image

Inclusive Tax

image

image

@StaberindeZA
fix(next): display correct list amount
a5f5c1c 
Because:

- List amount should not include exclusive tax.

This commit:

- Changes list amount to invoice.subtotal in DTO, to support inclusive
  and exclusive tax amounts.
- Adds currency to invoice preview
- Explicitly set a default currency to USD as a temporary solution.

Closes #fxa-10899
@StaberindeZA StaberindeZA requested a review from a team as a code owner December 20, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StaberindeZA