Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(graphql): Add recoveryPhone field to account resolver #18160

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dschom
Copy link
Contributor

@dschom dschom commented Dec 20, 2024

Because

  • We want to determine if an account has a recovery phone setup in settings.

This pull request

  • Adds the recoveryPhone field to the account resolver
  • Sets up DI for the recovery phone service
  • Adds some ts config for jest tests
  • Adds some ts config for build
  • Shifts providers into libs so they can be reused

Issue that this pull request solves

Closes: FXA-10486

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@dschom dschom requested a review from a team as a code owner December 20, 2024 02:18
Because:
- We want to determine if an account has a recovery phone setup in settings.

This Commit:
- Adds the recoveryPhone field to the account resolver
- Sets up DI for the recovery phone service
- Adds some ts config for jest tests
- Adds some ts config for build
- Shifts providers into libs so they can be reused
- Small improvement to typings and queries in recovery-phone.repository.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant