fix(settings): Navigate to confirmation if we don't have the recoveryKey #18156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can sometimes get into a point where the page is unloaded after a new recovery key is created. We want to gracefully handle this flow since the user is already verified. Fixes FXA-10869
vpomerleau
reviewed
Dec 19, 2024
| SensitiveData.Key.NewRecoveryKey | ||
| )?.recoveryKey; | ||
|
|
||
| if (!recoveryKey) { |
There was a problem hiding this comment.
I'm wondering if we should lift the check for sessionToken and uid out of the navigateNext function and above the check for recoveryKey - if that data is not in local storage then we might as well go directly to signin
vpomerleau
reviewed
Dec 19, 2024
| recoveryKeyId, | ||
| recoveryKeyExists, | ||
| estimatedSyncDeviceCount, | ||
| } = location.state as CompleteResetPasswordLocationState; | ||
|
|
||
| const kB = sensitiveDataClient.getDataType( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
recovery key is created. We want to gracefully handle this flow since
the user is already verified.
This pull request
/reset_password_confirmedif we don't have the recovery key anymore in theSensitiveDataClient.Issue that this pull request solves
Closes: FXA-10869
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
n/a
Other information (Optional)
Built on top of #18136. Will rebase when the prior PR lands.