Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task(content): Expose two strings for translation #18099

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

vpomerleau
Copy link
Contributor

Because

  • 2 strings on the pair choice page were not exposed for l10n

This pull request

  • Add tags for translation

Issue that this pull request solves

Closes: #FXA-10845

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

Because:

* 2 strings on the pair choice page were not exposed for l10n

This commit:

* Add tags for translation

Closes #FXA-10845
@vpomerleau vpomerleau requested a review from a team as a code owner December 4, 2024 21:09
@clouserw clouserw requested a review from a team December 4, 2024 21:12
Copy link
Contributor

@LZoog LZoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching!! 💎

@vpomerleau
Copy link
Contributor Author

Thank you for catching!! 💎

Caught by a localizer and filed by @bcolsson! Credit where credit is due.

@vpomerleau vpomerleau merged commit ec5ff1f into main Dec 4, 2024
26 checks passed
@vpomerleau vpomerleau deleted the FXA-10845 branch December 4, 2024 21:59
david1alvarez pushed a commit that referenced this pull request Dec 4, 2024
task(content): Expose two strings for translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants